[Mono-dev] [PATCH] Enable TLS for PPC32/64

Mark Probst mark.probst at gmail.com
Sat Jan 24 12:07:29 EST 2009


On Thu, 2009-01-22 at 09:03 -0600, Steven Munroe wrote:
> this patch completes the PPC64 port and enables Thread Local Storage
> under Linux/NPTL. This patch also provides the infrastructure for
> detecting PPC hardware attributes (via the SYSV Aux Vector) that we will
> need to optimize JIT code. For example this patch fixes
> mono_arch_flush_icache() used aux vector Hardware Capabilities
> (AT_HWCAP) info to avoid unnecessary dcbf/icbi sequences.

Thank you very much for this patch and all the legal difficulties that
went with it.

We don't commit patches this big in one swoop, so I had to split it up.
The order in which they are meant to be applied is:

  sm-codegen.diff
  sm-beautify.diff
  sm-small-fixes.diff
  sm-hwcap.diff
  sm-better-code.diff
  sm-icache.diff
  sm-tls.diff

The changes in sm-superfluous.diff seem, well, superfluous to me :-)

When contributing patches, please also use our coding style, especially
regarding indentation and where to put spaces:

  http://www.mono-project.com/Coding_Guidelines

I've fixed all of that in your code as far as it caught my eye.

Paolo: Please review the patches, especially the hwcap, icache and TLS
stuff.  I can't say much about those, but everything else looks fine,
and everything works (runtime and corlib regressions, tested on
PPC64/linux and PPC32/darwin).

Mark

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-superfluous.diff
Type: text/x-patch
Size: 2084 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0008.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-beautify.diff
Type: text/x-patch
Size: 4510 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0009.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-better-code.diff
Type: text/x-patch
Size: 3071 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0010.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-codegen.diff
Type: text/x-patch
Size: 20904 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0011.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-hwcap.diff
Type: text/x-patch
Size: 7154 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0012.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-icache.diff
Type: text/x-patch
Size: 1384 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0013.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-small-fixes.diff
Type: text/x-patch
Size: 852 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0014.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sm-tls.diff
Type: text/x-patch
Size: 7728 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090124/2eac7e4b/attachment-0015.bin 


More information about the Mono-devel-list mailing list