[Mono-dev] Monitor (lock) profiler patch

Massimiliano Mantione massi at ximian.com
Wed Feb 11 12:31:56 EST 2009


Hello,
this patch adds hooks to profile monitor activity.
I already have a profiler that uses it, and it works (I must finish the
post processing part but the event writing and decoding works well).

I only posted the runtime portion to keep the review easier...

I know the "MonoProfilerMonitorEvent" flags look a bit messy.
I made them that way for various reasons:
- be able to describe both "high level" meaning (enter, exit, success,
failure) and "internal details" (which we could change in the future),
- keep the bit count low so the profiler needs just one byte to write it
(even without processing logic), and
- do it with flags so that code that filters out uninteresting events
can be fast with as few branches as possible.
If you have better ideas for those flags propose them :-)

Apart from that I think the patch is straightforward.

Thanks!
  Massi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lock-profiler.patch
Type: text/x-patch
Size: 11115 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090211/85020ef7/attachment.bin 


More information about the Mono-devel-list mailing list