[Mono-dev] libgdiplus pango patch

[Sebastien Pouliot]

Hello Jonathan,

On Tue, 2009-02-10 at 13:53 +0700, Jonathan Anderson wrote:
> Hi all,
> 
> I was wondering if anyone has had a chance to look at my patch submitted 
> last week yet.  Any and all feedback is appreciated, and if I need to do 
> some more work to get this accepted, I just need to know what to do. 

I only had a quick look last week, but will look at it more carefully
soon.

A quick comment: it needs a ChangeLog ;-)

> Should I create a bug in the tracker to help track the work on complex 
> script support?

Yes, that would be useful - which brings me to a "long term" comment:
libgdiplus can't switch to pango output until it becomes a superset of
the features that it currently (custom text renderer) support - i.e.
complex script support is awesome but not enough as many people depends
on other features not yet available in the pango renderer.

> Thanks,
> Jonathan Anderson
> 
> Jonathan Anderson wrote:
> > I mentioned earlier that I was doing work to get pango support working 
> > properly in libgdiplus.  Here's a patch with my work so far.  Most of 
> > the formatting options are supported, but some of them aren't (like 
> > digit substitution), and some are not fully supported (like certain 
> > string trimming behavior).  I did my best to match gdi+ behavior as seen 
> > on Windows for things like white space trimming, new lines, wrapping, 
> > etc.  I've tested most of the options that I worked on with the 
> > exception of tab stops.
> > 
> > Let me know what you think.
> > 
> > I'm getting ready to do work on the TextBox control to get it to handle 
> > complex scripts better as well.  This will most likely end up in putting 
> > some pango and uniscribe (for Windows) calls in the TextBoxTextRenderer 
> > class.  One question I have about this, is would it be possible to have 
> > the Windows TextBox use pango?  I know that pango on windows will pass 
> > things through to uniscribe, and it would be easier to not have to use 
> > two different text rendering backends if possible.
> > 
> > Jonathan Anderson
> > 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list