[Mono-dev] [PATCH] Enable TLS for PPC32/64

[Paolo Molaro]

On 01/28/09 Steven Munroe wrote:
> if there WAS a problem will some chip in the past we address that
> separately. But this changes are important to the server class machines
> and I have carefully crafted this patch to only optimize for the case
> where we know (from the auxv) what the hardware actually is.
> 
> Don't penalize the latest hardware for the sins of the a chip that no
> one makes any more...

You're asking us to accept a possibly risky change without providing any
numbers on the benefits (which is what I requested in my mail).
Right now the only numbers I have are this: when profiling mono on ppc I
have never seen the icache flush function appear anywhere near the first
few pages of hot code. As you say the change is "important" you won't
have any difficulty in providing hard numbers and system information
where mono gets a speedup with the change (running something like mono
--compile-all /usr/local/lib/mono/2.0/gmcs.exe may be your best bet
for exercising the icache flushing, but any relevant benchmark using
mono you can come up with is fine).
If you're looking at improving the speed of mono on ppc I can suggest
many other things which will provide significant speedups (like for
example remove FORCE_INDIR_CALL in mini-ppc.c).

lupus

-- 
-----------------------------------------------------------------
lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better