[Mono-dev] Update C5 to v1.1.0
Zoltan Varga
vargaz at gmail.com
Thu Aug 6 15:57:36 EDT 2009
Hi,
Applied. Thanks!
Zoltan
On Thu, Aug 6, 2009 at 9:26 PM, Marcus Griep <marcus at griep.us> wrote:
> I have posted an update with the unit tests disabled.
>
> Because the first patch was large and difficult to prepare in the first
> place, I have let it be, and added a second, meta patch, which is to be
> applied to the results of the first patch. Here are the links again:
>
> http://wiki.xpdm.us/_media/mono/v1.1.0.patch.gz
> http://wiki.xpdm.us/_media/mono/v1.1.0.meta.patch
>
> They should be applied in that order, and the result should `make check`
> properly.
>
> I still have not heard back from the original maintainers, so I will be
> working proactively to maintain the library going forward, including
> fixing up the test cases and general code base to quality expectations.
>
> On Fri, 2009-07-31 at 13:46 +0200, Zoltan Varga wrote:
> > Hi,
> >
> > Since the old version could run its unit tests under mono, the new
> > version should too, or the
> > failing tests should be disabled.
> >
> > Zoltan
> >
> > On Fri, Jul 31, 2009 at 1:48 AM, Marcus Griep <marcus at griep.us> wrote:
> > I did notice these, and I'll go over each of them. I figured
> > that the
> > priority was getting the verbatim upstream ported over and
> > then fixing
> > them since the upstream hasn't been maintained since this
> > version was
> > released.
> >
> > Several hash table tests depend on DEBUG-mode specific
> > behavior; when
> > compiled with DEBUG defined, hash tables use a preset seed,
> > but when
> > compiled for release, hash tables are randomized. The majority
> > of the
> > failures in the unit tests are due to this.
> >
> > There is one failure that is due to a method not being
> > implemented in
> > v1.1.0, hence the "not implemented" exception. I can correct
> > this as
> > well.
> >
> > What would be the proper way to proceed here?
> >
> >
> >
> > On Thu, 2009-07-30 at 22:40 +0200, Zoltan Varga wrote:
> > > Hi,
> > >
> > > The patch applies cleanly, but there are some test
> > failures when
> > > running 'make check'
> > > in the Mono.C5 directory.
> > >
> > > Zoltan
> > >
> > > On Thu, Jul 30, 2009 at 5:49 PM, Marcus Griep
> > <marcus at griep.us> wrote:
> > > I am not attaching the patch here directly because,
> > even
> > > gzip'ed, it
> > > stands at over 450KB. Instead, it is being hosted at
> > > http://wiki.xpdm.us/_media/mono/v1.1.0.patch.gz
> > >
> > > The library in general is still in need of some TLC,
> > and as
> > > the upstream
> > > hasn't been updated in a year and a half, I am
> > trying to
> > > contact the
> > > original developers of C5 to determine if there will
> > be
> > > further
> > > development. If not, I will likely be maintaining a
> > new
> > > repository for
> > > C5 and plan to continue maintaining and developing
> > the C5
> > > library, as
> > > well as providing updates for Mono.C5.
> > >
> > > Also, be aware that there may be line ending issues
> > when
> > > applying this
> > > patch.
> > >
> > > --
> > > Marcus Griep
> > > GPG Key ID: 0x070E3F2D
> > > ——
> > > https://torproj.xpdm.us
> > > Ακακια את.ψο´, 3°
> > >
> > > _______________________________________________
> > > Mono-devel-list mailing list
> > > Mono-devel-list at lists.ximian.com
> > >
> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
> > >
> > >
> >
> > --
> >
> > Marcus Griep
> > GPG Key ID: 0x070E3F2D
> > ——
> > https://torproj.xpdm.us
> > Ακακια את.ψο´, 3°
> >
> >
> --
> Marcus Griep
> GPG Key ID: 0x070E3F2D
> ——
> https://torproj.xpdm.us
> Ακακια את.ψο´, 3°
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090806/2d72ece6/attachment.html
More information about the Mono-devel-list
mailing list