[Mono-dev] [PATCH] emit_marshal_boolean fix.

Bill Holmes billholmes54 at gmail.com
Thu Apr 9 16:49:55 EDT 2009


Hi,

I have updated my patch files from yesterday.  After some more testing
I discovered an uninitialized variable in the MARSHAL_ACTION_CONV_IN
case of emit_marshal_boolean.

-bill

2009-04-09  Bill Holmes  <billholmes54 at gmail.com>

	* marshal.c (emit_marshal_boolean): Adding code to ensure that
	  the correct TRUE value is passed through the marshaling layer.

	Code is contributed under MIT/X11 license.

2009-04-09  Bill Holmes  <billholmes54 at gmail.com>

	* Makefile.am: Adding marshalbool.cs.

	* libtest.c: Adding native code for marshalbool.cs tests.

	* marshalbool.cs: Adding tests for emit_marshal_boolean.

	Contributed under MIT/X11 license.

On Wed, Apr 8, 2009 at 5:02 PM, Bill Holmes <billholmes54 at gmail.com> wrote:
> Hi,
>
> We have a few bugs in our (my company's) code dealing with marshaling
> bools.  Our code has some cases where BOOL (true=1) and VARIANT_BOOL
> (true=-1) are mixed.  With ms.net it appears that they correct these
> mistakes when transitioning to and from managed code.
>
> The attached patch implements that behavior in emit_marshal_boolean.
> Also I have attached a unit test for my changes.
>
> -bill
>
>
> 2009-04-08  Bill Holmes  <billholmes54 at gmail.com>
>        * marshal.c (emit_marshal_boolean): Adding code to ensure that
>          the correct TRUE value is passed through the marshaling layer.
>
>        Code is contributed under MIT/X11 license.
>
> 2008-04-08  Bill Holmes  <billholmes54 at gmail.com>
>
>        * Makefile.am: Adding marshalbool.cs.
>
>        * libtest.c: Adding native code for marshalbool.cs tests.
>
>        * marshalbool.cs: Adding tests for emit_marshal_boolean.
>
>        Contributed under MIT/X11 license.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: marshalbool.patch
Type: application/octet-stream
Size: 5858 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090409/d8858e4f/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: marshalbooltests.patch
Type: application/octet-stream
Size: 39512 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090409/d8858e4f/attachment-0003.obj 


More information about the Mono-devel-list mailing list