[Mono-dev] [PATCH] Windows runtime tests hung.

[Rodrigo Kumpera]

The changes are ok.

On Wed, Apr 1, 2009 at 2:25 PM, Bill Holmes <billholmes54 at gmail.com> wrote:

> Understood, that is why I said it was a workaround.
>
> In my opinion the problems with QueueUserAPC are well know and do not
> need these particular three tests to remind us of that.  Can we work
> around a well know issue to allow these tests to exercise what they
> are intended to.
>
> -bill
>
> On Wed, Apr 1, 2009 at 10:33 AM, Rodrigo Kumpera <kumpera at gmail.com>
> wrote:
> > This is only a hack around the fact the we don't support proper
> interruption
> > on windows.
> >
> >
> > 2009/4/1 Bill Holmes <billholmes54 at gmail.com>
> >>
> >> Hi,
> >>
> >> On Windows some of the runtime tests are not completing since r127661
> >> (I believe.)  The attached patch is a workaround for the affected
> >> tests.
> >>
> >> On Windows we rely on QueueUserAPC to increment
> >> thread_interruption_requested.  The way the tests are currently
> >> written there is no opportunity to execute the APC.  Adding a sleep
> >> provides that opportunity.
> >>
> >> -bill
> >>
> >> 2009-04-01  Bill Holmes  <billholmes54 at gmail.com>
> >>
> >>        * finalizer-abort.cs, finalizer-exception.cs, finalizer-exit.cs :
> >>          Adding a sleep to the waiting thread to give Mono on Windows an
> >>          opportunity to interrupt the thread via QueueUserAPC.
> >>
> >>        Contributed under MIT/X11 license.
> >>
> >> _______________________________________________
> >> Mono-devel-list mailing list
> >> Mono-devel-list at lists.ximian.com
> >> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >>
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090401/2e40bb0d/attachment.html