[Mono-dev] [PATCH] Implement .NET 2.0 API for UnixListener and UnixClient

[Alan McGovern]

Hey,

This isn't a full review, it's just me point out some stuff I notice. Here
it goes:

+        public IAsyncResult BeginAcceptSocket (AsyncCallback callback,
object state)
+        {
+            if (server == null)
+                throw new ObjectDisposedException (GetType ().FullName);
+
+            return(server.BeginAccept (callback, state));

Why not just call CheckDisposed () as is done in BeginAccept ()?

+#if NET_2_0
+        public Socket Server
+#else
+        protected Socket Server
+#endif

I think the usual way to write this is:

+#if NET_2_0
+        public
+#else
+        protected
+#endif
          Socket Server

2008/10/17 Vlad Hociota <vladhociota at yahoo.com>

> Hi Jonathan.
>
> This is a stab at doing the updates we've discussed: implement new
> properties and methods for UnixListener and UnixClient similar to those
> exposed by TcpListener and TcpClient in .NET 2.0 . Please review.
>
> Thanks,
> Vlad
>
>
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081017/771dad3c/attachment-0001.html