[Mono-dev] [PATCH] bug 431001: Exception using XmlTextReader

[Rodrigo Kumpera]

Hi Brian,

The usual way to post patches for existing bugs in to use bugzilla. But
posting to the mailing list is ok.

But since your have already posted it to bugzilla, there is no need to re do
it on the mailing list as maintainers
monitor its activity and would have seen it.

Anyway, about your patch, catching ObjectDisposedException is not the way to
fix it as this is just a hack
around the root of the issue. This has severe performance implication as
well, as exception handling is one
of the slowest parts of the VM.

Rodrigo



2008/10/2 Brian Browning <bwbrowning at gmail.com>

> This is my first time contributing to mono, so let me know if this looks
> ok, or if I did something wrong please.
>
> This patch handles the exception, passes the test case given in the bug
> report,  and it passes all current tests.
> My only fear is that there is some detail of XmlSchema and XmlTextReader
> that I am overlooking that needs to be handled.
>
> Thanks,
> Brian
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081005/2c31903c/attachment.html