[Mono-dev] Fwd: Patch for DataGridView crash after Columsn.Clear

[jingnan si]

Hi!,
    The r119060 code fix my previous problem, but it introduce another
crash, my application is too complex, so I put a simple test code in the
attachment to show how the crash occurs . I just take a simple look at the
crash, it seems the DataGridView.OnColumnRemovedInternal has a bug.
    The test code is a simple form with DataGridView and a Button, click on
the button will crash the application.

Regards,
Jingnan

2008/11/18 Jonathan Pobst <monkey at jpobst.com>

> Hi!
>
> When I started writing some tests to verify your changes, I realized that
> RowTemplate should never contain any Cells.  I made changes to make us
> behave more like .Net.
>
> I don't know what your original issue is, so I do not know if this fixes
> it, but the changes I made are in r119060.  If you can still reproduce a
> crash, please let us know.
>
> Thanks!
> Jonathan
>
>
> jingnan si wrote:
>
>>
>>
>> ---------- Forwarded message ----------
>> From: *jingnan si* <jingnan.si <http://jingnan.si>@gmail.com <
>> http://gmail.com>>
>> Date: 2008/11/17
>> Subject: Re: [Mono-dev] Patch for DataGridView crash after Columsn.Clear
>> To: Andreas Färber <andreas.faerber at web.de <mailto:andreas.faerber at web.de
>> >>
>>
>>
>> Hi,
>>   I checked with latest version from svn, the bug is partially fixed, but
>> still crash the application, I re-make the diff file and attached based on
>> the svn latest code (At revision 118988), please check.
>>
>> Regards,
>> Jingnan
>>
>> 2008/11/16 Andreas Färber <andreas.faerber at web.de <mailto:
>> andreas.faerber at web.de>>
>>
>>    Hi,
>>
>>    Am 13.11.2008 um 02:35 schrieb jingnan si:
>>
>>
>>        diff -r
>>
>>  mono-2.0/mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGridViewColumnCollection.cs
>>
>>  original/mono-2.0/mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGridViewColumnCollection.cs
>>        105,108c105
>>        <             //list.Clear();
>>        <             while(Count > 0)
>>        <                 RemoveAt(0);
>>        <
>>        ---
>>         >             base.List.Clear ();
>>
>>    [...]
>>
>>    Please use unified diffs (`diff -u` or `svn diff`) for readability.
>>    Did you check it's not already fixed in SVN trunk?
>>
>>    Regards,
>>
>>    Andreas
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081118/4b2afb96/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestDataGrid.tar.gz
Type: application/x-gzip
Size: 5864 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081118/4b2afb96/attachment.gz