[Mono-dev] [PATCH] appdomain-unload crashes

[Rodrigo Kumpera]

On Fri, Nov 7, 2008 at 3:00 PM, Gonzalo Paniagua Javier <
gonzalo.mono at gmail.com> wrote:

> On Fri, 2008-11-07 at 13:32 -0200, Rodrigo Kumpera wrote:
> > Hey guys,
> >
> > The attached patch fixes the appdomain unloading problem. I can no
> > longer get the
> > test to crash here.
> [...]
>
> I see 2 problems. One which you already pointed out about not executing
> the last element. I'm not sure that we should even try to execute it, as
> MS documentation says that no new threads are allowed to use the domain
> that is unloading and, I guess, we can add that not thread in the
> threadpool should switch to use the dying domain.
>

The job when "remaining_jobs == 0" must be executed as this happens under
normal
conditions when the queue gets emptied.



>
> The other one is that we should block / ignore any new threadpool item
> from the domain being unloaded. The attached test, exits quickly on MS
> and keeps running forever with Mono.
>
> -Gonzalo
>
>
Good point, this is unrelated to this patch, but I'll work on it as well.



Cheers,
Rodrigo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081107/d97d077c/attachment-0001.html