[Mono-dev] Contributing Code for ObservableCollection

[Brian O'Keefe]

Hello,

I've updated my code to conform to the coding guidelines.  My tests pass
under both mono and the MS framework.  I'll attach the patch file for my
changes.

~Brian

On Sat, Nov 1, 2008 at 6:59 PM, Alan McGovern <alan.mcgovern at gmail.com>wrote:

> Hey,
>
> Read here: http://www.mono-project.com/Contributing and also here
> http://www.mono-project.com/Coding_Guidelines.
>
> Though my word is most definitely *not* the final word in any discussion, I
> will say that if the code isn't covered by NUnit tests, it won't be
> committed ;) So just ensure that for every method you've implemented, there
> are one or more tests for it. From your email, it looks like you've already
> done this, which is great!
>
> Also, just to verify, do all the tests pass when run under both the MS
> framework and mono?
>
> Thanks.
> Alan.
>
> 2008/11/1 Brian O'Keefe <zer0keefie at gmail.com>
>
>> Hello,
>>
>> I've been following the Mono project for a while, and had some free time,
>> so I figured I'd use some of that time to contribute.  I've used the
>> ObservableCollection class frequently
>> (WindowsBase>System.Collections.Specialized.ObservableCollection) and
>> noticed that it wasn't implemented in Mono.  This seemed like a fairly
>> simple class to implement, so I thought I'd start there.  I have some code
>> for ObservableCollection and its backing infrastructure (the
>> NotifyCollectionChanged* classes) and matching test cases.
>>
>> What would be the best way to contribute the changes I made?  There are
>> six modified files and three test case files.
>>
>> ~Brian
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081103/ebba8238/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: WindowsBase_bokeefe.diff
Type: application/octet-stream
Size: 55470 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20081103/ebba8238/attachment-0001.obj