[Mono-dev] AsQueriable patch

Jb Evain jb at nurv.fr
Thu May 15 07:38:03 EDT 2008


Hey Roei,

On 5/15/08, Roei Erez <roeie at mainsoft.com> wrote:
> Attached is a proposed patch for 'AsQueryable' extension method.

Niiice!

> The implementation traverses the tree and replaces the 'IQueryable' methods
> with the corresponding 'IEnumerable' methods.
>
> Please review

Looks mostly good, a few things to do before you commit:

* move the ExpressionTransformer to the ns Sys.Linq.Expressions,
* rename EnumerableAsQueryable to QueryableEnumerable,
* rename ExpressionTransformer.VisitExpressionList to VisitList,
* rename QueryableExpressionTransformer to QueryableTransformer,
* add license and copyright information to the new files,
* comment out the tests that make gmcs crash, and mark them with a TODO,

Thanks a lot,

-- 
Jb Evain  <jb at nurv.fr>


More information about the Mono-devel-list mailing list