[Mono-dev] [PATCH] Fixes and improvements for mixed-mode assembly support

[Rodrigo Kumpera]

Hi Kornél,

What is the reason of your changes in threads.c? I can't see it making any
diference and it's possibly racy as there is no membar around the new static
variable.

@@ -203,7 +221,7 @@
 	IMAGE_DOS_HEADER* DosHeader;
 	IMAGE_NT_HEADERS* NtHeaders;
 	DWORD* Address;
-	DWORD dwOldProtect;
+	DWORD OldProtect;


Please avoid this variable renaming as it bloats the patch. If renaming is
really needed, it should be a separate patch.


Thanks,
Rodrigo



2008/5/9 Kornél Pál <kornelpal at gmail.com>:

> Hi,
>
> Mixed-mode assembly support is currently (temporarily) disabled in SVN.
> This patch is supposed to fix the issue reported by Jonathan and reenable
> mixed-mode assembly support.
>
> May I commit this patch?
>
> Also note that I have added some mixed-mode assembly tests in r102861 that
> can be compiled using Visual Studio 2005 or later.
> MixedModeLibrary/NativeApp is a special case because it tests _CorDllMain
> and loads mono.dll so has to be executed without mono.exe.
>
> Kornél
>
> ----- Original Message ----- From: "Kornél Pál"
> To: "mono-devel"
> Cc: "Zoltan Varga"; "Jonathan Chambers"
> Sent: Monday, May 05, 2008 10:56 AM
> Subject: [PATCH] Fixes and improvements for mixed-mode assembly support
>
>
>
>  Hi,
>>
>> * domain.c: Open exe_image anyway so that it can be fixed up. Add a
>> mono_close_exe_image function that closes exe_image.
>>
>> * image.c: Fix reference counting when DLL image is loaded using
>> LoadLibrary
>> outside of image.c.
>>
>> * threads.c: Add threads_initialized that enables coree.c to call
>> mono_thread_suspend_all_other_threads at any time.
>>
>> * coree.c: Some improvements and add mono_set_act_ctx that loads manifest
>> file from the main assembly when process is created from mono.exe. This is
>> required for MSVCRT support but may be used by other assemblies as well
>> for
>> example for XP Visual Style support.
>>
>> Please review the patch and if you like it, please approve it.
>>
>> Jonathan, please try this patch if it fixes the issue you have reported.
>>
>> Kornél
>>
>>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080509/c42a9f18/attachment.html