[Mono-dev] Fw: [Mono-patches] r106776 - in trunk/mcs/class/System.Configuration: System.Configuration Test/System.Configuration

Atsushi Eno atsushi at ximian.com
Fri Jun 27 18:47:33 EDT 2008


http://lists.ximian.com/pipermail/mono-devel-list/2008-June/028336.html

> Atsushi,
>
> If you can find ANY, I mean, ANY insult I addressed to you then please show
> me.
>
> Gert
>
> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Atsushi Eno
> Sent: zaterdag 28 juni 2008 0:08
> To: monodanmorg at yahoo.com
> Cc: mono-devel-list at lists.ximian.com
> Subject: Re: [Mono-dev] Fw: [Mono-patches] r106776 - in
> trunk/mcs/class/System.Configuration: System.Configuration
> Test/System.Configuration
>
> As usual, I didn't start insulting posts from my side. Though I'm
> pretty much positive to return the same (and more) words to the starter.
>
> Atsushi Eno
>
> Daniel Morgan wrote:
>   
>> Comments from eno like the one below is one of the main reasons I no
>>     
> longer felt motivated to contribute to mono.  In particular, mono's ado.net
> implementation. Not that my contributions were worth much, but still it
> belittles anyones' Non-Ximian/Novell contributions to mono...
>   
>> --- On Fri, 6/27/08, Atsushi Enomoto (atsushi at ximian.com)
>>     
> <mono-patches-list at lists.ximian.com> wrote:
>   
>>> From: Atsushi Enomoto (atsushi at ximian.com)
>>>       
> <mono-patches-list at lists.ximian.com>
>   
>>> Subject: [Mono-patches] r106776 - in
>>>       
> trunk/mcs/class/System.Configuration: System.Configuration
> Test/System.Configuration
>   
>>> To: mono-patches at lists.ximian.com, ximian.monolist at gmail.com,
>>>       
> mono-svn-patches-garchive-20758 at googlegroups.com
>   
>>> Date: Friday, June 27, 2008, 4:45 PM
>>> Author: atsushi
>>> Date: 2008-06-27 16:45:49 -0400 (Fri, 27 Jun 2008)
>>> New Revision: 106776
>>>
>>> Modified:
>>>   
>>> trunk/mcs/class/System.Configuration/System.Configuration/ChangeLog
>>>   
>>>
>>>       
> trunk/mcs/class/System.Configuration/System.Configuration/ConfigurationError
> sException.cs
>   
>>>   
>>> trunk/mcs/class/System.Configuration/Test/System.Configuration/ChangeLog
>>>   
>>>
>>>       
> trunk/mcs/class/System.Configuration/Test/System.Configuration/Configuration
> ErrorsExceptionTest.cs
>   
>>> Log:
>>> 2008-06-27  Atsushi Enomoto  <atsushi at ximian.com>
>>>
>>>         * ConfigurationErrorsException.cs : recover from
>>>           silly change that tries to prevent debuggin by
>>>           decreasing error location information.
>>>
>>>         * ConfigurationErrorsExceptionTest.cs : mark couple
>>>           of tests as [Ignore] that blocks us from decent
>>>           implementation in the name of silly .NET
>>> compatibility.
>>>
>>>         Maybe I'll remove more silliness later.
>>>
>>>
>>>
>>> Modified:
>>> trunk/mcs/class/System.Configuration/System.Configuration/ChangeLog
>>> ===================================================================
>>> ---
>>> trunk/mcs/class/System.Configuration/System.Configuration/ChangeLog
>>>       
> 2008-06-27
>   
>>> 20:45:31 UTC (rev 106775)
>>> +++
>>> trunk/mcs/class/System.Configuration/System.Configuration/ChangeLog
>>>       
> 2008-06-27
>   
>>> 20:45:49 UTC (rev 106776)
>>> @@ -1,3 +1,9 @@
>>> +2008-06-27  Atsushi Enomoto  <atsushi at ximian.com>
>>> +
>>> +	* ConfigurationErrorsException.cs : recover from
>>> +	  silly change that tries to prevent debuggin by
>>> +	  decreasing error location information.
>>> +
>>>  2008-06-26  Gert Driesen 
>>> <drieseng at users.sourceforge.net>
>>>  
>>>  	* ConfigurationElement.cs: Use
>>> ConfigurationErrorsException instead of
>>>
>>> Modified:
>>>
>>>       
> trunk/mcs/class/System.Configuration/System.Configuration/ConfigurationError
> sException.cs
>   
>>> ===================================================================
>>> ---
>>>
>>>       
> trunk/mcs/class/System.Configuration/System.Configuration/ConfigurationError
> sException.cs	2008-06-27
>   
>>> 20:45:31 UTC (rev 106775)
>>> +++
>>>
>>>       
> trunk/mcs/class/System.Configuration/System.Configuration/ConfigurationError
> sException.cs	2008-06-27
>   
>>> 20:45:49 UTC (rev 106776)
>>> @@ -143,18 +143,21 @@
>>>  		//
>>>  		public static string GetFilename (XmlReader reader)
>>>  		{
>>> +			// FIXME: eliminate this silly compatibility.
>>>  			if (reader is IConfigErrorInfo)
>>>  				return ((IConfigErrorInfo) reader).Filename;
>>> -			else
>>> -				return null;
>>> +
>>> +			return reader != null ? reader.BaseURI : null;
>>>  		}
>>>  
>>>  		public static int GetLineNumber (XmlReader reader)
>>>  		{
>>> +			// FIXME: eliminate this silly compatibility.
>>>  			if (reader is IConfigErrorInfo)
>>>  				return ((IConfigErrorInfo)
>>>       
> reader).LineNumber;
>   
>>> -			else
>>> -				return 0;
>>> +
>>> +			IXmlLineInfo li = reader as IXmlLineInfo;
>>> +			return li != null ? li.LineNumber : 0;
>>>  		}
>>>  
>>>  		public static string GetFilename (XmlNode node)
>>>
>>> Modified:
>>> trunk/mcs/class/System.Configuration/Test/System.Configuration/ChangeLog
>>> ===================================================================
>>> ---
>>> trunk/mcs/class/System.Configuration/Test/System.Configuration/ChangeLog
>>>       
> 2008-06-27
>   
>>> 20:45:31 UTC (rev 106775)
>>> +++
>>> trunk/mcs/class/System.Configuration/Test/System.Configuration/ChangeLog
>>>       
> 2008-06-27
>   
>>> 20:45:49 UTC (rev 106776)
>>> @@ -1,3 +1,9 @@
>>> +2008-06-27  Atsushi Enomoto  <atsushi at ximian.com>
>>> +
>>> +	* ConfigurationErrorsExceptionTest.cs : mark couple
>>> +	  of tests as [Ignore] that blocks us from decent
>>> +	  implementation in the name of silly .NET compatibility.
>>> +
>>>  2008-06-26  Gert Driesen 
>>> <drieseng at users.sourceforge.net>
>>>  
>>>  	* ConfigurationErrorsExceptionTest.cs: Added tests for
>>> ctors and
>>>
>>> Modified:
>>>
>>>       
> trunk/mcs/class/System.Configuration/Test/System.Configuration/Configuration
> ErrorsExceptionTest.cs
>   
>>> ===================================================================
>>> ---
>>>
>>>       
> trunk/mcs/class/System.Configuration/Test/System.Configuration/Configuration
> ErrorsExceptionTest.cs	2008-06-27
>   
>>> 20:45:31 UTC (rev 106775)
>>> +++
>>>
>>>       
> trunk/mcs/class/System.Configuration/Test/System.Configuration/Configuration
> ErrorsExceptionTest.cs	2008-06-27
>   
>>> 20:45:49 UTC (rev 106776)
>>> @@ -194,6 +194,7 @@
>>>  		}
>>>  
>>>  		[Test] // ctor (String, XmlReader)
>>> +		[Ignore ("Asserting that the exception has less
>>> information is an idiot's way to go.")]
>>>  		public void Constructor5 ()
>>>  		{
>>>  			string msg;
>>> @@ -311,6 +312,7 @@
>>>  		}
>>>  
>>>  		[Test] // ctor (String, Exception, XmlReader)
>>> +		[Ignore ("Asserting that the exception has less
>>> information is an idiot's way to go.")]
>>>  		public void Constructor7 ()
>>>  		{
>>>  			string msg;
>>> @@ -606,6 +608,7 @@
>>>  		}
>>>  
>>>  		[Test] // GetFilename (XmlReader)
>>> +		[Ignore ("Asserting that the exception has less
>>> information is idiot's way to go.")]
>>>  		public void GetFilename1 ()
>>>  		{
>>>  			string xmlfile = Path.Combine (foldername,
>>> "test.xml");
>>>
>>> _______________________________________________
>>> Mono-patches maillist  -  Mono-patches at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-patches
>>>       
>>       
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>     
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
>   



More information about the Mono-devel-list mailing list