[Mono-dev] [Patch] to significantly shorten Char.cs

Rodrigo Kumpera kumpera at gmail.com
Thu Jun 26 17:49:26 EDT 2008


Your patch have a huge ammount of useless whitespace changes, these make
reviews a lot hard.

Please provide some benchmarks so we can run it locally and see the
performance improvements.

I would say that moving the argumento checks to a funcion is a bad idea. We
should move the exception
raising part, thou.



2008/6/26 Andreas Nahr <ClassDevelopment at a-softtech.com>:

> The attached patch reduces code duplication in Char by more than 130 lines
> and improves the performance of some methods a little bit.
>
> Somebody please have a short look...
>
> Happy Hacking
> Andreas
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080626/76d0255b/attachment.html 


More information about the Mono-devel-list mailing list