[Mono-dev] DataSet.Merge() fix wrt DataRelation createConstraints

Atsushi Eno atsushi at ximian.com
Thu Jun 19 11:21:19 EDT 2008


This time the patch is about DataSet.Merge(). It fixes the final
nunit test failure. DataTableReadWriteXmlTest.TestReadXml, the
failing test, exposes failure in DataTable.Read(), but it is actually
about DataSet.Merge() which is used in the method above.

It should not create DataRelation with "createConstraints" as always
false. It should be based on the source DataRelation.

The field createConstraints should be preserved for merge, so
I also made some fix in DataRelation too.

This change exposed wrong createConstraints handling in
XmlSchemaDataImporter too, so this patch also includes fix for it.

If the fix looks good, I'll commit it later.

Atsushi Eno
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dataset-merge-constraints.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080620/631e91f9/attachment-0001.pl 

More information about the Mono-devel-list mailing list