[Mono-dev] DataColumn.DefaultValue fixes

Atsushi Eno atsushi at ximian.com
Thu Jun 12 12:06:40 EDT 2008


I have a fix for one of failing sys.data test in 2.0 profile. Here
is description (could be used for ChangeLog):

* System.Data/DataColumn.cs
  DefaultValue can be non-DBNull. For SqlXxx type, it becomes
  SqlXxx.Null. Also, changing DataType may change DefaultValue
  to be consistent with the new type (say, having int DefaultValue
  for new string DataType is wrong).

* System.Data/XmlSchemaWriter.cs
  This should be fixed to take non-DBNull default value into

* Test/System.Data/DataTableTest.cs, Test/System.Data/DataSetTest.cs
  We could use default value as is, not in string form. This makes
  comparison more strict.

* Test/System.Data/DataColumnTest.cs
  Added test for non-DBNull case and changing DataType case.

If it looks good, I'll check in it later.

Atsushi Eno

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: column-default-value-fix.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080613/8e1682aa/attachment.pl 

More information about the Mono-devel-list mailing list