[Mono-dev] Next part of string patch (replace). Please test.

[Andreas Nahr]

Thanks for testing. Good catch!

 

Fixed and added more testcases to check for that.

 

Happy Hacking

Andreas

 

Von: Konstantin Triger [mailto:kostat at gmail.com] 
Gesendet: Dienstag, 3. Juni 2008 13:38
An: Andreas Nahr
Cc: mono-devel-list at lists.ximian.com
Betreff: Re: [Mono-dev] Next part of string patch (replace). Please test.

 

Hello all,

To my understanding,

The following line:
if (count <= maxValue)

should be: 
if (count < maxValue)

2008/6/2 Andreas Nahr <ClassDevelopment at a-softtech.com>:

This time the change is much smaller ;)

Adds some additional Unittests and some explanatory LAMESPECS.
For additional explanation see the last String patch mail or the original
mailing-list discussion.
For me all Unittests (including the new ones) pass. Did not observe
regressions.

Happy Hacking
Andreas

P.S.
After that only split is missing...

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list




-- 
Regards,
Konstantin Triger
RSS: http://feeds.feedburner.com/ktriger 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080603/94026c14/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: StringReplace.patch
Type: application/octet-stream
Size: 13593 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080603/94026c14/attachment-0001.obj