[Mono-dev] [PATCH] HTML encode attributes that might need encoding

Marek Habersack grendello at gmail.com
Sat Jul 26 06:33:09 EDT 2008

On Fri, 25 Jul 2008 21:52:34 -0700
"Dean Brettle" <dean at brettle.com> wrote:

> Hi all,
Hey Dean,

> Please review the attached small patch and let me know if it is OK to commit
> this to mono-2-0 and trunk.  All existing tests pass, but I haven't added
> any new tests specifically for the changes.  It's not clear whether it is
> worth the effort for this change.  Feedback welcome.  Here's the ChangeLog
Since the current tests don't check whether HTML special chars are encoded, I think
it would be a good idea to add tests along with this change. Also, have you compared
the output with what .NET produces in such cases? Otherwise, the patch looks good to
go in.

best regards,


> entry:
> 2008-07-25  Dean Brettle <dean at brettle.com>
>     * HtmlControl.cs (PreProcessRelativeReference),
>     HtmlForm.cs (RenderAttributes), HtmlInputButton (RenderAttributes),
>     HtmlInputRadioButton (RenderAttributes), HtmlSelect (RenderChildren):
>     Encode attributes that could contain HTML special chars.
> Thanks,
> --Dean
> !DSPAM:2,488aad94243988811816156!

More information about the Mono-devel-list mailing list