[Mono-dev] [PATCH] Fixes for races and other bugs in App_Browsers/*.browser processing

[Dean Brettle]

Hi all,

Please review the attached patch and let me know if it is OK to commit to
mono-2-0 and trunk.  Here is the ChangeLog entry:

2008-07-25  Dean Brettle <dean at brettle.com>

    * nBrowser/Node.cs nBrowser/Build.cs nBrowser/Identification.cs: Fixed
race
    condition in Node.Process() by removing mutating functions from
Identification
    and    changing Node.Process() and Node.BrowserIdentification() to
maintain
    state in a List<Match> instead of a List<Identification>.

    * nBrowser/Node.cs: Fixed race condition associated with lookup of
adapter
    types.

    * nBrowser/Node.cs: Removed duplicate call to
Node.BrowserIdentification() from
    Node.Process().

    * nBrowser/Node.cs: Removed duplicate call to Result.AddAdaper() from
Node.Process().

    * nBrowser/Node.cs: Fixed bug where capabilities containing literal $ or
% were
    dropped.

    * nBrowser/Node.cs: Fixed bug where capabilities with multiple $
substitutions only
    had one applied.


Thanks,
--Dean
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080725/d555579f/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nBrowser.patch
Type: text/x-patch
Size: 22545 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080725/d555579f/attachment-0001.bin