[Mono-dev] [PATCH] CodeGenerator/CodeDom classes (again)

Juraj Skripsky js at hotfeet.ch
Thu Jan 24 03:59:20 EST 2008


Hello,

This is the third time I'm posting this (no counting my first,
Visitor-less version). Nobody provided any feedback so far...


Attached you'll find patches for CodeGenerator.cs and quite a few
System.CodeDom classes. They implement the Visitor pattern for the
CodeGenerator (traverser) and the classes in System.CodeDom (nodes to be
visited)*. The result is much nicer and faster code.

The patch is big only because it contains a lot of boiler plate code.

ChangeLog entries are included, all unit tests pass.
Please review (or at least comment...)

- Juraj


*) Thanks again to Robert Jordan, for sketching out how to apply the
Visitor pattern to the CodeGenerator/CodeDom classes!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CodeDom_latest.patch
Type: text/x-patch
Size: 45703 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080124/1d3634cd/attachment.bin 


More information about the Mono-devel-list mailing list