[Mono-dev] [PATCH] Aditional visibility checks for mono

Rodrigo Kumpera kumpera at gmail.com
Fri Jan 18 16:34:26 EST 2008


The attached patch implements two missing visibility checks under mono. The
first is to fully check the visibility of the type. The second one is proper
family visibility checks, that require access to the static type of the
'this' parameter on stack. The current patch passes a full bootstrap.

Curently all tests are under the verifier suite, once the patch is approved,
I'll extract regression tests to put under mono/tests.

There is one issue with this patch thou. In some cases it's not possible to
perform the full family visibility checks. It happens when one constructor
is inlined inside another constructor and, for some reason I still don't
know, sometimes the type of the 'this' argument ends been System.Object. I
need some help on this subject as I'm trying to debug this for two days now.
It shows when compiling System.dll, for example. It was quite hard to track
this bug because all it does is to make some methods not inlinable.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080118/3524e173/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: visibility_patch.diff
Type: text/x-patch
Size: 13398 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080118/3524e173/attachment.bin 

More information about the Mono-devel-list mailing list