[Mono-dev] [PATCH] CodeGenerator/CodeDom classes

Juraj Skripsky js at hotfeet.ch
Wed Jan 16 04:55:35 EST 2008


Hello,

Could somebody please review this patch?
Thanks.

- Juraj


On Wed, 2008-01-09 at 22:59 +0100, Juraj Skripsky wrote:
> Hello,
> 
> Attached you'll find patches for CodeGenerator.cs and quite a few
> System.CodeDom classes. Also included is a new file ICodeDomVisitor.cs
> which belongs into System/System.CodeDom. ChangeLog entries are
> included.
> 
> These patches replace those (ugly ones) I posted on Jan 6th. They
> implement the Visitor pattern for the CodeGenerator (traverser) and the
> classes in System.CodeDom (nodes to be visited)*. The result is much
> nicer and faster code.
> 
> *) Thanks again Robert Jordan, for sketching out how to apply the
> Visitor pattern to the CodeGenerator/CodeDom classes!
> 
> All unit tests pass.
> Please review.
> 
> - Juraj
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list




More information about the Mono-devel-list mailing list