[Mono-dev] [PATCH] Simplifying/optimizing CodeGenerator.cs

[Juraj Skripsky]

Hi Robert,

I don't see how to use the visitor pattern in the implementation of
CodeGenerator. But I'm probably to close to the details right now to see
the big picture.

Could you roughly describe how you meant to apply the visitor pattern to
this class?

- Juraj


On Sun, 2008-01-06 at 23:15 +0100, Robert Jordan wrote:
> Hi Juraj,
> 
> Juraj Skripsky wrote:
> > Hi,
> > 
> > Attached you'll find a patch for CodeGenerator.cs (in
> > System.CodeDom.Compiler). It simplifies two methods considerably and
> > might also bring a small performance improvement (perf. tests pending).
> 
> I think using a visitor pattern would be more appropriate.
> Performance and style-wise.
> 
> Robert
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>