[Mono-dev] [PATCH] corlib GetCustomAttributes for overriden properties bug

[Ivan N. Zlatev]

On Tue, Feb 26, 2008 at 1:05 PM, Ivan N. Zlatev <contact at i-nz.net> wrote:
> On Tue, Feb 26, 2008 at 5:47 AM, Raja R Harinath <harinath at hurrynot.org> wrote:
>  > Hi,
>  >
>  >
>  >  "Ivan N. Zlatev" <contact at i-nz.net> writes:
>  >
>  >  > On Mon, Feb 25, 2008 at 9:43 PM, Ivan N. Zlatev <contact at i-nz.net> wrote:
>  >  >> Please review the attached patch that fixes our behavior to match MS's
>  >  >>  in terms of GetCustomAttributes for overridden attributes on
>  >  >>  properties. That is:
>  >  >>   * PropertyInfo.GetCustomAttributes - Inherit parameter is ignored and
>  >  >>  behavior defaults to false
>  >  >>   * Attributes.GetCustomAttributes - Inherit parameter is not ignored
>  >  >>   * Attributes.IsDefined - Inherit parameter is not ignored on the 2.0 profile.
>  >  >>
>  >  >>  This patch fixes bugs #324472 and #322464. Also now all our Attribute
>  >  >>  tests pass on 1.1 and 2.0 profiles(woho!). Please say whether it's
>  >  >>  okay to commit and if the fixes should be backported.
>  >  >>
>  >  >
>  >  > The previous patch did not handle indexed properties. Attached is an
>  >  > updated patch. I did a clean rebuild with the patch applied - no
>  >  > breakages. All Attributes tests pass.
>  >  >
>  >  > Zoltan, what do you think?
>  >
>  >  Since this affects reflection, one good testcase is that it doesn't
>  >  break the compiler.  Can you check that this doesn't break
>  >
>  >   make compiler-tests
>  >
>  >  (you need to run this from the mono/ tree).
>  >
>
>  Done that and there are no breakages. I talked with Zoltan on IRC last
>  night and he said the patch looks okay. I am going to commit it.
>

For the record - committed as revision 96632.

-- 
Ivan N. Zlatev

Web: http://www.i-nZ.net
"It's all some kind of whacked out conspiracy."