[Mono-dev] [PATCH] Implement internal Encodings using unified code base

Kornél Pál kornelpal at gmail.com
Mon Feb 25 09:07:35 EST 2008


Hi,

Please review the attached patch.

First of all this patch fixes
https://bugzilla.novell.com/show_bug.cgi?id=363713

This patch only contains infrastructural changes that result in the
following:
- GetByteCount, GetBytes, GetCharCount, GetChars have one implementation per
encoding
- all internal encodings now use usafe code that results in better
performance
- internal encodings use the fastest possible code path to these
implementations
- inherited encodings use MS.NET compatible code paths
- encoding code can be maintained much easier
- argument checks are shared so code can't go out of sync

Note that no actual encoding algorytms are changed so there should be no
behavioral changes.

Also note that I added an InternalEncoding class that is only used by
Latin1Encoding currenly but I will later figure out some hack to integrate
external (I18N assemblies) encoding classes to this infrastructure and that
will use this InternalEncoding class.

Kornél 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Encodings.diff.zip
Type: application/x-zip-compressed
Size: 12153 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080225/74caf6ca/attachment-0001.bin 


More information about the Mono-devel-list mailing list