[Mono-dev] Somebody please test this String patch

[Leszek Ciesielski]

I am getting a failure in PROFILE=net_2_0 tests:

Failures:
1) MonoTests.System.DateTimeOffsetTest.ToStringWithFormatAndCulture :
        String lengths are both 37.
        Strings differ at index 0.

        expected:<"Thursday, Nov 01 2007 09:00:00 -07:...">
         but was:<"czwartek, lis 01 2007 09:00:00 -07:...">
        -----------^

  at MonoTests.System.DateTimeOffsetTest.ToStringWithFormatAndCulture
() [0x00025] in
/home/skolima/workspace/mono_svn/mcs/class/corlib/Test/System/DateTimeOffsetTest.cs:174
  at (wrapper managed-to-native)
System.Reflection.MonoMethod:InternalInvoke (object,object[])
  at System.Reflection.MonoMethod.Invoke (System.Object obj,
BindingFlags invokeAttr, System.Reflection.Binder binder,
System.Object[] parameters, System.Globalization.CultureInfo culture)
[0x00055] in /home/skolima/workspace/mono_svn/mcs/class/corlib/System.Reflection/MonoMethod.cs:149

My locale is set to Polish. "czwartek" is Thursday in Polish, and
"lis" is short for "listopad" (November).

Aaaand I'm getting the same failure without the patch, so that's a
mistake in the tests.


On Feb 8, 2008 8:39 AM, Andreas Nahr <ClassDevelopment at a-softtech.com> wrote:
> Anybody?
>
> Apart from a very small issue this could be applied to mono and no feedback
> at all?
>
> Greetings
> Andreas
>
> > -----Ursprüngliche Nachricht-----
> > Von: mono-devel-list-bounces at lists.ximian.com
> > [mailto:mono-devel-list-bounces at lists.ximian.com] Im Auftrag
> > von Andreas Nahr
> > Gesendet: Donnerstag, 31. Januar 2008 22:42
> > An: 'mono-devel'
> > Betreff: Re: [Mono-dev] Somebody please test this String patch
>
> >
> > Attached is a new version.
> > As far as I can tell with a cygwin setup it passes all
> > relevant unittests and is able to compile mono without any
> > problems. It also adds a few unittest for cases that are
> > currently incorrectly implemented in the string class.
> >
> > Happy Hacking
> > Andreas
> >
> > > -----Ursprüngliche Nachricht-----
> > > Von: mono-devel-list-bounces at lists.ximian.com
> > > [mailto:mono-devel-list-bounces at lists.ximian.com] Im Auftrag von
> > > Andreas Nahr
> > > Gesendet: Montag, 28. Januar 2008 01:52
> > > An: 'mono-devel'
> > > Betreff: [Mono-dev] Somebody please test this String patch
> > >
> > > This patch tries to get string a little bit out of its miserable
> > > shape:
> > >
> > > It fixes several bugs, and implements the majority of the remaining
> > > internalcalls with optimized managed code, giving performance
> > > increases for the most cases (sometimes quite a lot).
> > >
> > > Fixed is:
> > > Bugs in parameterchecks for StartsWith, IndexOf, LastIndexOf Marked
> > > possible bug in:
> > > Compare
> > > Managed Implementations of:
> > > PadRight, PadLeft, LastIndexOfAny, StringCopy, Trim, TrimStart,
> > > TrimEnd, Split (Char versions), ToCharArray
> > >
> > > It is not yet completely tested, but it would be nice if
> > somebody else
> > > could help a little bit - it's an important class after all ;)
> > >
> > > The patch also makes most of the String-icall.c file obsolete.
> > >
> > > Some raw perfomance numbers for tests I did:
> > >
> > > Trim:
> > > 1813 -> 1290
> > > 631  -> 550
> > > 1332 -> 421
> > > 7441 -> 2754
> > > 6319 -> 9303
> > >
> > > Split:
> > > 10174 -> 5718
> > > 982   -> 871
> > > 7921  -> 7170
> > > 26809 -> 7980
> > > 18506 -> 11290
> > >
> > > Pad:
> > > 8021 -> 8100
> > > 1612 -> 1663
> > > 841  -> 861
> > > 1642 -> 1682
> > > 821  -> 71
> > >
> > > LastIndexOfAny:
> > > 2253 -> 2243
> > > 1773 -> 1362
> > > 6990 -> 6470
> > > 1883 -> 2240
> > > 831  -> 2240
> > >
> >
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>



-- 
MS-DOS user since 5.0
Windows user since 3.11
Linux user since kernel 2.4
Novell Netware user since 2.2
WARCRAFT user since 1.0