[Mono-dev] [PATCH] mono-service bugs - please review

Jonathan Pryor jonpryor at vt.edu
Thu Feb 7 15:56:06 EST 2008

On Thu, 2008-02-07 at 15:38 -0500, Avery Pennarun wrote:
> So I need to submit a new lockfile patch.  Any comments on the
> UserInteractive stuff?  That's actually the part I'm most suspicious
> that I did wrong.

System.Environment.SetUserInteractive() needs comments, similar to what
Mono.Runtime.GetDisplayName() has:

    // Should not be removed intended for external use
    // Safe to be called using reflection
    // Format is undefined only for use as a string for reporting

It need not be identical to that, but it should say that this method,
even though it's private and isn't referenced anywhere else in
mscorlib.dll, is there so that mono-service.exe can execute it via
Reflection, and thus should not be modified w/o updating mono-service.

Beyond that, you should search around mcs/class to see if anything
depends on the UserInteractive property (I doubt that anyone does, but
you should check to be sure).

 - Jon

More information about the Mono-devel-list mailing list