[Mono-dev] [PATCH] mono-service bugs - please review

Jörg Rosenkranz joerg.rosenkranz at gmail.com
Thu Feb 7 05:50:55 EST 2008


Hi Avery,

2008/2/5, Avery Pennarun <apenwarr at gmail.com>:
> Note that it currently is implemented by polling every 500ms, which is lame
> on multiple levels (you don't want daemons waking up every 500ms on your
> laptop for no reason, as it wastes power).  I eagerly await your signal
> patch.

I knew it was ugly when I wrote this, but it seemed to be the best
solution at the time. It should have been implemented as
AutoResetEvent but that can't be used in signal handlers.
I don't think that signals are the way to go in the future. Maybe
someone takes a look at D-BUS for stearing services?

> - mono-service can overwrite its lockfile if the lockfile isn't
>   lockf'ed.  This seems to be what was originally intended, but didn't
>   quite get implemented correctly.

Did you have a look at bug #77340
(https://bugzilla.novell.com/show_bug.cgi?id=MONO77340)? For me it
looks like you are reopening this security hole with your patch.

Joerg.



More information about the Mono-devel-list mailing list