[Mono-dev] [PATCH] System.Messaging/AMQP: Receive, Send and Peek implementation

[Atsushi Eno]

Hello,

Michael Barker wrote:
>> After a couple of struggle with build system, it's in trunk now :)
> 
> Cool I have it checked out now.
> 
>> I made a horrible hack in RabbitMQ/Makefile that now it includes every
>> sources outside src/client as DISTFILES. There may be better way to
>> reduce this kind of mess. Probably we can build things from bootstrap?
>> We can mark some assemblies as NO_INSTALL=yes.
> 
> Yes, I will need to understand the build process a bit better and see
> how the RabbitMQ libraries should be built.  The build for RabbitMQ
> relies on a code generator to generate some of the client classes from
> the AMQP spec XML, so it therefore has a bootstrap process of its own,
> which makes it a little awkward to integrate into the mono build.

If the code generator only generates autogenerated-api-*.cs, they do not
have to be generated in every build, as long as they can be generated
manually within the files included in the sources.

For src/util/*.cs files, they have to be kept up to date in DISTFILES in
RabbitMQ.Client/Makefile. Or some better makefile trick could apply.

So far, current horrible hack would work ;)

> A couple of newbie contributor questions:
> 
> - What is the best handle configuration, e.g. allowing a user to
> specify which messaging provider they want to use?  Should I use
> System.Configuration?

System.Configuration.dll is only within 2.0, though I wouldn't care
much for dropping 1.x support. We could alternatively use environment
variable (we use it for registry and eventlogs for example).

> - Is there any preference WRT posted patches on the list or via bugzilla?

For non-bugfixes this list would work better.

Atsushi Eno