[Mono-dev] [PATCH] eglib memory allocation changes

Miguel de Icaza miguel at novell.com
Sat Aug 2 00:07:10 EDT 2008


Hello,

> I tracked a bug to load_modules in image.c.  In this particular case
> image->modules was being set to a non-null value when the
> image->module_count was equal to 0.  There is another area of the code
> later that checks the modules but not he module_count and causes an
> assert.  I could have simply changed this code but after reading the
> glib documentation I believe that this patch is the right change.
> Also there may be more critical areas that I have not discovered yet
> that could hit this problem.

It would be useful to add unit test cases so this behavior is also
enforced in the code.  Mind adding those?

Miguel.



More information about the Mono-devel-list mailing list