[Mono-dev] [Patch] Mono.Security.StrongName.Verify: added a stream overload

[Andreas Färber]

Hi Dave,

Am 25.04.2008 um 16:08 schrieb Dave Hillier:

> For future reference, what's wrong with the line endings?

I don't spot any line ending issues either on first sight, however you  
appear to replace some tabs with 8 spaces in StrongName.cs.

Andreas

> On 25 Apr 2008, at 15:08, Sebastien Pouliot wrote:
>
>> Hello Dave,
>>
>> It looks ok, except maybe for the ?line endings? on the last few  
>> lines
>> of the diff.
>>
>> Do you have commit rights ? If so check the last part issue before
>> committing. Otherwise tell me and I'll check that before committing.
>>
>> Thanks!
>> Sebastien
>>
>> On Fri, 2008-04-25 at 14:27 +0100, Dave Hillier wrote:
>>> Hi,
>>>
>>> I have added an overload to Mono.Security.StrongName.Verify which
>>> takes a Stream rather than a file name. This allows me to verify  
>>> byte
>>> code I have already loaded in memory, saving an unnecessary write to
>>> disc. I have preserved the old interface and refactored the code so
>>> they both use the same path.
>>>
>>> I have attached the patch which contains the changes to  
>>> StrongName.cs
>>> and StrongNameTest.cs
>>>
>>>
>>> Cheers,
>>>
>>> Dave
>>>
>>>
>>>
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list