[Mono-dev] Replicating System.Web.Script.Serialization bugs
R. Tyler Ballance
tyler at monkeypox.org
Sat Oct 20 07:53:39 EDT 2007
-----BEGIN PGP SIGNED MESSAGE-----
On Oct 15, 2007, at 2:14 AM, Konstantin Triger wrote:
> Hey Tyler,
> 1. Your code must come AFTER 'if (type == null)' for obvious reasons.
> The best place would be just before 'return Convert.ChangeType (obj,
> type);' at the end of the function.
> 2. Please add the following test cases (passing on MS .Net):
> Converting to Nullable<> from empty and non-empty strings.
I went ahead and committed in r 87847 (and r 87848 because I'm an
idiot and forgot to move the code down and only realized after I
checked with null >_<)
Anyways, I'm a bit unsure where I should commit the test, I'm
assuming in System.Web.Extensions/Test/
I'm just unsure because I see gert commit tests like a madman
- -R. Tyler Ballance
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
-----END PGP SIGNATURE-----
More information about the Mono-devel-list