[Mono-dev] [PATCH] String.Split() broken behavior

[Miguel de Icaza]

Hey!

> Attached is a revised patch to the String.Split problem. This patch now 
> includes code cleanup to bring it in conformance with the published 
> coding standards as well as unit tests relevant to the changes I made.

Thanks for the contribution!

> For what its worth, I would suspect that this function is probably the 
> fastest basic tokenization mechanism available though the class 
> libraries. The reason why I found the bugs in this code to begin with is 
> because I always used this method to tokenize input strings. Indeed, I'm 
> surprised that these bugs went unnoticed and unrepaired for so long 
> (literally years) for such a critical core component as the system 
> string library.

SplitOptions was introduced in the 2.0 API and we only got around to
doing the current implementation in response to IronPython calling it
recently (eight months ago?)

Miguel.