[Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows

[Kornél Pál]

Hi,

An updated version of the patch is attached. Please review this one as well.

Kornél

----- Original Message ----- 
From: "Robert Jordan" <robertj at gmx.net>
To: <mono-devel-list at lists.ximian.com>
Sent: Monday, November 05, 2007 2:03 PM
Subject: Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for Windows


Hi Kornél,

Kornél Pál wrote:
> Hi,
>
> I intalled the latest cygwin available and it has no winternl.h (or any
> equivalent header). On the other hand it has the DDK headers bundled.
>
> A possible solution is to use winternl.h with MS VC++ and the DDK headers
> with cygwin. What about that?

this would be OK.

Robert

>
> Kornél
>
> ----- Original Message ----- 
> From: "Robert Jordan" <robertj at gmx.net>
> To: <mono-devel-list at lists.ximian.com>
> Sent: Monday, November 05, 2007 1:03 PM
> Subject: Re: [Mono-dev] [PATCH] ShellExecuteEx ProcessId support for 
> Windows
>
>
> Hi Kornél,
>
> Kornél Pál wrote:
>> HAVE_GETPROCESSID depends on WINVER that is not set, so
>> HAVE_GETPROCESSID is
>> never defined on Windows. This means that GetProcessId never gets called
>> on
>> Windows and process ID is allways 0.
>>
>> This patch adds run-time detection for GetProcessId on Windows.
>>
>> Note that only Windows XP SP1 and above have GetProcessId API while
>> Windows
>> 2000 and above have deprecated NtQueryInformationProcess API that can be
>> used for the same purpose.
>>
>> Please review and approve this patch.
>
> it's not acceptable to depend on the DDK headers. I wonder
> why do you need them in the first place, since the required
> defines are also provided by SDK's winternl.h.
>
> Robert
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win_pid2.diff
Type: application/octet-stream
Size: 3478 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20071105/347da029/attachment.obj