[Mono-dev] Win64 Patch II

[Kornél Pál]

Hi,

g_path_is_absolute should handle both \ and / as path separator. This is 
handled by glib. Note that paths starting with \\ (double backslash) are 
rooted UNC paths. This isn't handled by glib either but may cause problems 
if it's ignored.

libgc/include/private/gcconfig.h:
+#     if defined(__LP64__) || defined(_WIN64)
+# define X86_64
+#     else
+#       define I386
+#     endif

_WIN64 is defined for IA64 as well so I think x64 should not be assumed 
based on _WIN64. MS VC++ defines _M_IA64 and _M_X64 respectively that I 
think should be checked in addition to _WIN64.

None of the above are critical problems but care should be taken to 
eliminate future problems.

Kornél

----- Original Message ----- 
From: "Jonathan Chambers" <joncham at gmail.com>
To: "Andreas Färber" <andreas.faerber at web.de>
Cc: "Miguel de Icaza" <miguel at novell.com>; "mono-devel" 
<mono-devel-list at lists.ximian.com>
Sent: Sunday, November 04, 2007 5:49 PM
Subject: Re: [Mono-dev] Win64 Patch II


I committed the eglib part. The mono and libgc parts need reviewed/approved.

Thanks,
Joanthan

On 11/4/07, Andreas Färber <andreas.faerber at web.de> wrote:
>
>
> Am 03.11.2007 um 23:17 schrieb Miguel de Icaza:
>
> > The eglib changes are OK to go into SVN.
>
> Looks okay to me, too.
>
> Do you have SVN access yourself, Jonathan? It was the second okay by
> Miguel already.
>
> Andreas
>



--------------------------------------------------------------------------------


> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>