[Mono-dev] Mono on Windows/x64

Andreas Färber andreas.faerber at web.de
Tue May 1 10:12:49 EDT 2007


>       Sorry, I didn't intentionally ignore your patch. The one from  
> Michael was so large I didn't try to merge the two. I'll merge in  
> your changes you submitted and repost unless someone else gets to  
> it first.

This is not personal, it's just about the results: it appears the  
review process isn't working so well here ... a correct  
implementation gets rejected due to the lack of autoconf magic and an  
incorrect implementation (potentially dropping the last char) that  
uses autoconf gets in...

Anyway, this way you made me aware of a bug in my original patch not  
specially treating a NULL argument. See attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: conf-eglib64.sh
Type: application/octet-stream
Size: 450 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070501/f5f841fa/attachment.obj 
-------------- next part --------------
  Please review and let me know whether this is fully correct now and  
whether or not errno should be set (Linux' strndup does according to  
documentation, but does eglib need it?) so that I can commit the fix  
and avoid further conflicts.

For the rest of my patches at http://bugzilla.ximian.com/show_bug.cgi? 
id=81456 I am still struggling with configure not detecting the  
presence of the iconv library.


More information about the Mono-devel-list mailing list