[Mono-dev] (no subject)

[Vladimir Krasnov]

Hello, 

Please review a performance optimization for HttpRequest.Headers and
HttpRequest.ServerVariables collections.
It implements lazy collection fill because most common flow is to ask
for value by name. Only if user ask for enumerator or count, collection
will be fully loaded.
This gives about 25% performance improvement on common flow.

This causes one test case to fail:
MonoTests.System.Web.Test_HttpFakeRequest.Test_EmptyUnknownRow :
NullReferenceException was expected,
in my opinion this test is incorrect, and should be removed, because it
tests undocumented behavior that may depend on implementation.

Vladimir	
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ServerVariablesCollection.cs.patch
Type: application/octet-stream
Size: 9646 bytes
Desc: ServerVariablesCollection.cs.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: WebROCollection.cs.patch
Type: application/octet-stream
Size: 374 bytes
Desc: WebROCollection.cs.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment-0001.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BaseParamsCollection.cs.patch
Type: application/octet-stream
Size: 2135 bytes
Desc: BaseParamsCollection.cs.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HeadersCollection.cs.patch
Type: application/octet-stream
Size: 1729 bytes
Desc: HeadersCollection.cs.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment-0003.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HttpRequest.cs.patch
Type: application/octet-stream
Size: 1204 bytes
Desc: HttpRequest.cs.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment-0004.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: System.Web.dll.sources.patch
Type: application/octet-stream
Size: 492 bytes
Desc: System.Web.dll.sources.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070329/f71cc0ec/attachment-0005.obj