[Mono-dev] [PATCH] System.Web.Services: support for interface service declaration

[Atsushi Eno]

Hi,

Thanks for the patch. I have some comments:

	- Does this change intended to include private methods
	  (BindingFlags.NonPublic) in a *class* as well as
	  private interface implementation? If yes why?
	- I'm not sure that comparing methods in your own way is
	  good. At least comparing ParameterInfo just by Type
	  does not look good enough.
	- Is ConformanceChecker change relevant, or is this just
	  a fix that happened to be included? If yes please commit
	  this one individually (having test case is much better).

Atsushi Eno

Konstantin Triger wrote:
> Hello all,
> 
> Attached patch enables web service declaration of the following form.
> Please review.
> 
> namespace WebService3
> {
> 	[WebServiceBinding (Namespace = "urn:contoso:com")]
> 	public interface IServiceContract
> 	{
> 		[WebMethod]
> 		string HelloWorld ();
> 	}
> 
> 	[WebService (Namespace = "urn:contoso:com1")]
> 	public class Service2 : IServiceContract
> 	{
> 		public string HelloWorld () { return ""; }
> 
> 		[WebMethod]
> 		public string HelloWorld1 () { return ""; }
> 	}
> }
> 
> Regards,
> Konstantin Triger
>