[Mono-dev] System.Configuration patches

Chris Toshok toshok at ximian.com
Wed Jan 31 18:16:26 EST 2007


The System.Configuration maintainers might be better equipped to answer
this, but I'll give it a go:


both patches need indentation work.

the ConfigSource one looks fine to me.

the ConfigurationElement.cs patch looks wrong.  A test case for this
would be useful (to verify that the TypeConverter property is correct),
and should be easy to create.

Also, we shouldn't be using System.Reflection at all for that method.
We should be using System.ComponentModel, with
TypeDescriptor/PropertyDescriptor (and
their respective TypeConverter method/property).  That'll simplify the
code a bunch.

Chris




More information about the Mono-devel-list mailing list