[Mono-dev] HttpWebRequest method patch

[Jonathan Pryor]

Not speaking about the possible RFC violation, I see one issue with the
patch:

On Mon, 2007-01-29 at 08:46 +0900, Atsushi Eno wrote:
> Index: System.Net/HttpWebRequest.cs
> ===================================================================
> --- System.Net/HttpWebRequest.cs        (revision 71778)
> +++ System.Net/HttpWebRequest.cs        (working copy)
> @@ -372,7 +372,23 @@
>                                 if (value == null || value.Trim () == "")
>                                         throw new ArgumentException ("not a valid method");
>  
> -                               method = value;
> +                               // LAMESPEC: This class is not really case
> +                               // sensitive for those methods here, which
> +                               // would violate RFC 2616 (5.1.1).
> +                               string upper = value.ToUpperInvariant ();
> +                               switch (value.ToUpperInvariant ()) {

Shouldn't you switch on `upper' here, so that you don't
call .ToUpperInvariant() twice?

 - Jon