[Mono-dev] patch to add some missing System.Diagnostics trace stuff

Atsushi Eno atsushi at ximian.com
Wed Jan 17 23:14:27 EST 2007


Hi,

Thanks for the comments :)

>> +	* TRaceSourceTest.cs, SourceSwitchTest.cs : new tests.
> 
> You mis-spelled TraceSourceTest.cs. :-)

oops ;-)

>> +		protected internal virtual string [] GetSupportedAttributes ()
>> +		{
>> +			return null;
> 
> Shouldn't this return `new string[0]'?  At least that would be more
> consistent with the .NET Framework Design Guidelines.

Actually I just implemented it along with MSDN documentation. Now
I have added another test case for it in SwitchesTest.cs. I will
checkin soon.

Atsushi Eno



More information about the Mono-devel-list mailing list