[Mono-dev] Please approve commit change to System.Web.Hosting/ApplicationHost.cs

[Adar Wesley]

Hi All,

 

I would like to commit a change to ApplicationHost.  The suggested diff
follows:

 

svn diff System.Web.Hosting/ApplicationHost.cs

Index: System.Web.Hosting/ApplicationHost.cs

===================================================================

--- System.Web.Hosting/ApplicationHost.cs       (revision 70723)

+++ System.Web.Hosting/ApplicationHost.cs       (working copy)

@@ -81,12 +81,9 @@

                        if (physicalDir == null)

                                throw new NullReferenceException ();

 

-#if NET_2_0

+                       // Make sure physicalDir has file system
semantics

+                       // and not uri semantics ( '\' and not '/' ).

                        physicalDir = Path.GetFullPath (physicalDir);

-#endif

-                       // This might throw

-                       Uri u = new Uri (physicalDir);

-                       physicalDir = HttpUtility.UrlDecode
(u.AbsolutePath);

 

 

The reasoning is that physicalDir should have file system semantics and

not URI semantics.  The Path.GetFullPath() API fixes all the slashes to
be

correct for the OS.

 

This is true both for version 1.1 and 2.0.

 

Thanks,

 

Adar Wesley

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070109/c56b08bc/attachment.html