[Mono-dev] Proposed patch for DirectoryInfo.MoveTo

[Boris Kirzner]

Hello
Attached is a reworked patch.

May I commit?


Thanks,
Boris

-----Original Message-----
From: Sebastien Pouliot [mailto:sebastien.pouliot at gmail.com] 
Sent: Tuesday, February 13, 2007 9:02 PM
To: Boris Kirzner
Cc: mono-devel-list at ximian.com
Subject: Re: [Mono-dev] Proposed patch for DirectoryInfo.MoveTo

Hello Boris,

On Tue, 2007-02-13 at 08:04 -0800, Boris Kirzner wrote:
> Attached patch fixes DirectoryInfo.MoveTo: the full path should be
> updated if MoveTo succeeds.
> 
>  
> 
> Please review
> 
                public void MoveTo (string dest) {
                        Directory.Move (FullPath, Path.GetFullPath
(dest));
+                       this.FullPath = Path.GetFullPath (dest);
                }

Path.GetFullPath is kind of heavy so it would be better to store it's
result in a string variable and use this string on both calls.
 
> 
> Thanks,
> 
> Boris
> 
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

-------------- next part --------------
A non-text attachment was scrubbed...
Name: moveto.patch
Type: application/octet-stream
Size: 1382 bytes
Desc: moveto.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070213/4bf2ffa3/attachment.obj