[Mono-dev] Proposed patch for Directory and DirectoryInfo

Sebastien Pouliot sebastien.pouliot at gmail.com
Tue Feb 6 11:56:35 EST 2007


Hello Boris,

In this patch, like the previous one, the source isn't formatted
correctly, i.e. it doesn't follow Mono source style.

E.g. tabulations, missing spaces before '(', '{' at the wrong place...

Otherwise it seems you have tests to cover most cases :)

Did you try running the CAS unit tests too ? (they are ignored by
default).

Thanks
Sebastien

On Tue, 2007-02-06 at 07:16 -0800, Boris Kirzner wrote:
> Hello all
> 
>  
> 
> Attached is a proposed patch for Directory and DirectoryInfo. Note
> that this patch is incremental relative to previous Path patch I sent.
> 
>  
> 
> Main patch points:
> 
>       * Fixed CreateSubdirectory logic (including windows-specific
>         checks)
>       * DirectoryInfo path should be updated after move
>       * Fixed CreateDirectory logic for negative flows
>       * Exists fix (empty path never exists)
> 
>  
> 
>  
> 
> Please review.
> 
> Boris
> 
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
-- 
Sebastien Pouliot  <sebastien at ximian.com>
Blog: http://pages.infinit.net/ctech/




More information about the Mono-devel-list mailing list