[Mono-dev] [PATCH] System.Text.Encoding.GetEncoding compatibility fixes

Atsushi Eno atsushi at ximian.com
Thu Feb 1 07:44:04 EST 2007


Hi,

(I've already approved the patch but) I had to revert part of it since
it broke the build. You can try to use non-Latin1 environment (e.g.
CP932) to see how it breaks mcs tree.

Atsushi Eno

Gert Driesen wrote:
> Hi,
> 
> The attached patch fixes some minor differences between our and MS'
> Encoding.GetEncoding implementation.
> 
> * GetEncoding (int): do not allow codepage value below zero
> and above 0xffff.
> * GetEncoding (string): modified NotSupportedException to
> ArgumentException when encoding is not supported
> 
> Both changes are covered by unit tests.
> 
> Let me know if it's ok to commit.
> 
> Gert




More information about the Mono-devel-list mailing list