[Mono-dev] [PATCH] Perform bounds check on table decode

Zoltan Varga vargaz at gmail.com
Sun Dec 30 17:10:30 EST 2007


This is ok to check in.

       Zoltan

On Dec 30, 2007 10:58 PM, Rodrigo Kumpera <kumpera at gmail.com> wrote:
> Hey,
>
> The attached patch adds an assert in both mono_metadata_decode_row(_col). I
> think it's better to assert than access random data.
>
> On the other hard, functions that decode metadata tables must perform such
> checks and raise the apropriate error. The attached patch fixes that for
> mono_get_method_from_token, which is what I have tests for now. Most of this
> bounds checking could be done in mono_method_to_ir, which would avoid
> tripping into the metadata stuff.
>
> Just one thing, the test requires that my previous patch to ilasm be
> applied.
>
>
>  Rodrigo
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>



More information about the Mono-devel-list mailing list