[Mono-dev] [PATCH] DriveInfo implementation - volume space

Javier Martín lordhabbit at gmail.com
Fri Dec 7 09:49:59 EST 2007


Dick Porter wrote:
>
>> Furthermore, and even more important, I was planning to add at least
>> two more functions in volumes.[hc] in other, unrelated patches to add
>> the "get/set volume label" functionality and correct the bug I
>> mentioned in the patch post (FS type not being detected in Windows).
>
>Note that io-layer is not used on Windows.

I know, the plan was to implement internal calls which would use Win32
functions (maybe GetVolumeInformation and SetVolumeLabel), then
implement POSIX-based substitutes in volumes.[hc]. As I said, the
extension of such changes still has to be better thought, but io.[hc]
is cluttered enough and there's a very high probability that more
functions end up in volumes.[hc].

>More importantly, we will need a copyright assignment for a code
>contribution this big, or a declaration that you wrote the code and it
>is contributed under the X11 licence.

Indeed. I, declare/swear/whatever, that I wrote the modifications I
posted, and I agree to license them under the X11 License as it
currently stands at http://www.opensource.org/licenses/mit-license.php
without any additional terms. My only sources were (1) MSDN for the
.NET & Win32 API specs and (2) Linux man pages for the statvfs spec.
Should I add any kind of notice to volumes.[hc]?

Habbit




More information about the Mono-devel-list mailing list