[Mono-dev] patch winform resource reader

[olivier dufour]

So, I have done a unit test (and run it on linux but not on windows) and fix
some bug thanks to it ;)
If someone can test it under the MS framework.
So here is a new patch with unit test and modified class. I have truncate
the patch to remove my other changes. So maybe it will not work. If you have
issue to patch with it mail me and I will try to make a new one.

cheers,
Olivier

2007/11/30, Gert Driesen <gert.driesen at telenet.be>:
>
> Olivier,
>
> As you mention in your patch, you need unit tests to verify whether the
> behavior matches the MS implementation.
>
> I suggest submitting a bug report, and attaching the current patch before
> continueing working on it.
>
> Thay way the patch will not get lost in all the "noise" ...
>
> Gert
> ----- Original Message -----
> From: "olivier dufour" <olivier.duff at gmail.com>
> To: <mono-devel-list at lists.ximian.com>
> Sent: Friday, November 30, 2007 7:45 AM
> Subject: [Mono-dev] patch winform resource reader
>
>
> > OK, I have done a small part at work. So I have forget to change the
> > convention on it.
> > I have attach the fixed patch.
> >
> >
> > 2007/11/30, Jb Evain <jb at nurv.fr >:
> >>
> >> Hey,
> >>
> >> On 11/30/07, olivier dufour < olivier.duff at gmail.com> wrote:
> >> > Can someone check it before I commit.
> >>
> >> Please do not commit this as it is. The code:
> >>
> >> * doesn't respect the Mono coding conventions,
> >> * mixes spaces and tabs all over the place.
> >>
> >> --
> >> Jb Evain  <jb at nurv.fr>
> >>
> >
>
>
>
> --------------------------------------------------------------------------------
>
>
> > _______________________________________________
> > Mono-devel-list mailing list
> > Mono-devel-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20071201/5c89399a/attachment.html 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch3.txt
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20071201/5c89399a/attachment.txt